Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: storacha skin #108

Closed
wants to merge 9 commits into from
Closed

feat: storacha skin #108

wants to merge 9 commits into from

Conversation

alanshaw
Copy link
Member

Screenshot 2024-07-19 at 16 09 14 Screenshot 2024-07-19 at 16 09 40 Screenshot 2024-07-19 at 16 09 54 Screenshot 2024-07-19 at 16 10 01 Screenshot 2024-07-19 at 16 10 09 Screenshot 2024-07-19 at 16 10 16

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 19, 2024 •
edited
Loading

Website preview 🔗✨

build log

@alanshaw alanshaw marked this pull request as ready for review July 31, 2024 16:58
@Peeja
feat: Improved layout styling, and other tales (#114)
d0a2208 
This was mainly a sweep of uses of `h-screen`, as it was breaking on
viewports shorter than the page contents, which was particularly nasty
on the Pricing page, which is long. I've also:

* Tweaked how the rooster shows up on small-width screens
* Made the "Terms of Service" text on the login screen black rather than
white for readability
* Made the hamburger menu icon red rather than write for readability
* Changed "w3up" to "Storacha"

Unfortunately, we don't have Storybook and Chromatic (or similar) to see
all the diffs, but I've screenshotted what I could. Note that these are
all full-page screenshots; the fact that the befores are cut off at the
top is exactly the problem I was solving here. 🙂

Plenty of this is subjective; thoughts, feedback, and corrections are
more than welcome.

### Before


![screencapture-localhost-3000-2024-08-02-16_00_56](https://github.com/user-attachments/assets/8f29fe4a-d078-4271-a3de-75ba30bbf67e)

![screencapture-localhost-3000-2024-08-02-16_02_16](https://github.com/user-attachments/assets/3b9f7b06-0d4d-401e-a90e-144d724f614a)

![screencapture-localhost-3000-2024-08-02-16_15_53](https://github.com/user-attachments/assets/78f31bfa-301c-440e-bdcf-e25962dd766a)

![screencapture-localhost-3000-2024-08-02-16_16_38](https://github.com/user-attachments/assets/a3c09240-a1d4-4029-81c0-6df4a3943a27)

![screencapture-localhost-3000-2024-08-02-16_27_53](https://github.com/user-attachments/assets/1fc08c56-0a58-46aa-939d-7b9aab5eafad)

### After


![screencapture-localhost-3000-2024-08-02-16_01_30](https://github.com/user-attachments/assets/39ec5a46-2dd2-407e-afc9-746e7288447b)

![screencapture-localhost-3000-2024-08-02-16_07_23](https://github.com/user-attachments/assets/78435c8c-d862-4051-ad2a-f51f3bb87a16)

![screencapture-localhost-3000-2024-08-02-16_16_06](https://github.com/user-attachments/assets/365539c3-5966-4885-bd63-dd51f4cfa3f7)

![screencapture-localhost-3000-2024-08-02-16_16_56](https://github.com/user-attachments/assets/dfdb7587-f06f-48cc-9dee-dcc1fff77a99)

![screencapture-localhost-3000-2024-08-02-16_28_11](https://github.com/user-attachments/assets/850af45e-b073-4a09-a420-79245a354c45)
@fforbeck fforbeck closed this Sep 17, 2024
@fforbeck fforbeck deleted the feat/storacha-skin branch September 17, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alanshaw @Peeja @fforbeck