Skip to content
This repository has been archived by the owner on Jul 29, 2019. It is now read-only.

WIP: Middleware log #35

Closed
wants to merge 8 commits into from
Closed

WIP: Middleware log #35

wants to merge 8 commits into from

Conversation

leohxj
Copy link
Collaborator

@leohxj leohxj commented Jul 26, 2019 •
edited
Loading

Log 中间件

Related issue link: #31

@leohxj leohxj self-assigned this Jul 26, 2019
@leohxj leohxj added the enhancement New feature or request label Jul 26, 2019
@leohxj leohxj added this to the 1.0 milestone Jul 26, 2019
@leohxj leohxj mentioned this pull request Jul 26, 2019
Open
@codecov
Copy link

codecov bot commented Jul 26, 2019

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #35   +/-   ##
=======================================
  Coverage   82.25%   82.25%           
=======================================
  Files           5        5           
  Lines         124      124           
  Branches       25       25           
=======================================
  Hits          102      102           
  Misses         22       22

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cabea8...95eb139. Read the comment docs.

@codecov
Copy link

codecov bot commented Jul 26, 2019 •
edited
Loading

Codecov Report

Merging #35 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #35   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           5      5           
  Lines         129    129           
  Branches       29     29           
=====================================
  Hits          129    129

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b60610d...2a72d42. Read the comment docs.

nonoroazoro
nonoroazoro reviewed Jul 26, 2019
View reviewed changes
packages/yab-fetch-middleware-log/tsconfig.json Outdated
"noFallthroughCasesInSwitch": true,
"moduleResolution": "node",
"baseUrl": "./",
"paths": {
Copy link
Collaborator

@nonoroazoro nonoroazoro Jul 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

没有 sub-packages 的话最好不要用 paths，代码会很难理解（baseUrl 也一并移除吧）

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok，这两个字段可以直接删除吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个 packages 我是用的 tsdx 脚手架生成的。

Copy link
Collaborator

@nonoroazoro nonoroazoro Jul 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

可以的啊，直接删除。另外感觉:

"include": [
  "src"
]

就行了

@leohxj leohxj marked this pull request as ready for review July 27, 2019 14:39
@leohxj
Copy link
Collaborator Author

leohxj commented Jul 28, 2019

和其他项目统一格式后后再PR

@leohxj leohxj closed this Jul 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nonoroazoro nonoroazoro nonoroazoro left review comments

Assignees

@leohxj leohxj

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@leohxj @nonoroazoro