Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Sync from open-cluster-management-io/multicloud-operators-subscription: #396 #1078

Merged
merged 2 commits into from
May 6, 2024
Merged

🤖 Sync from open-cluster-management-io/multicloud-operators-subscription: #396 #1078

merged 2 commits into from
May 6, 2024

Conversation

magic-mirror-bot[bot]
Copy link
Contributor

@magic-mirror-bot magic-mirror-bot bot commented May 6, 2024 •
edited
Loading

dhaiducek and others added 2 commits May 6, 2024 17:56
@dhaiducek
Upgrade kustomize (#395)
401b76d 
* Upgrade kustomize

Picks up a fix where error messages from plugins
weren't being returned.

Signed-off-by: Dale Haiducek <[email protected]>

* Set `IMAGE_TAG` for OCM install

Signed-off-by: Dale Haiducek <[email protected]>

---------

Signed-off-by: Dale Haiducek <[email protected]>
(cherry picked from commit e6948fc)
@xiangjingli
customize app addon install namespace (#396)
458138e 
Signed-off-by: Xiangjing Li <[email protected]>
(cherry picked from commit 25d7b3d)
@openshift-ci openshift-ci bot requested review from mikeshng and philipwu08 May 6, 2024 17:56
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 6, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: magic-mirror-bot[bot]
Once this PR has been reviewed and has the lgtm label, please assign rokej for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@magic-mirror-bot magic-mirror-bot bot mentioned this pull request May 6, 2024
Closed
@magic-mirror-bot magic-mirror-bot bot closed this May 6, 2024
@mikeshng mikeshng reopened this May 6, 2024
@mikeshng mikeshng requested review from xiangjingli and removed request for mikeshng and philipwu08 May 6, 2024 18:34
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 70%)

See analysis details on SonarCloud

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 6, 2024 •
edited
Loading

@magic-mirror-bot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/sonarcloud 458138e link true /test sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@xiangjingli
Copy link
Contributor

/test test-unit

@xiangjingli xiangjingli merged commit 7e824c3 into main May 6, 2024
7 of 10 checks passed
@xiangjingli xiangjingli deleted the magic-mirror-main-1715018192936 branch May 6, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangjingli xiangjingli Awaiting requested review from xiangjingli

Assignees
No one assigned
Labels
dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

😿 Failed to sync the upstream PRs: #396
3 participants
@xiangjingli @mikeshng @dhaiducek