look up tables for script blocks #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We merge this one but the LookupTable functionality needs to be refactored! #48 |
senny
added a commit
that referenced
this pull request
Sep 25, 2012
look up tables for script blocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script blocks need to be able to write to and read from lookup tables. They already have access to other simple definitions lookup tables by using
definition('other definition').identify_by(:id, 8)for example.What's missing is the ability of the script block to create its own lookup table. I have a use case where I need exactly such behavior. In this commit I took the simplest approach to make it possible.