Upgrade smoltcp to 0.12.0 #508
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlevora
force-pushed
the
smoltcp-0.12.0-upgrade
branch
from
20ebbb0
to
4bd4959
Compare
richardeoin
reviewed
Nov 29, 2024
src/ethernet/eth.rs
Outdated
| @@ -816,7 +816,7 @@ pub struct RxToken<'a, const RD: usize>(&'a mut RDesRing<RD>); | |||
| impl<'a, const RD: usize> phy::RxToken for RxToken<'a, RD> { | |||
| fn consume<R, F>(self, f: F) -> R | |||
| where | |||
| F: FnOnce(&mut [u8]) -> R, | |||
| F: FnOnce(&[u8]) -> R, | |||
| { | |||
| let result = f(unsafe { self.0.buf_as_slice_mut() }); | |||
There was a problem hiding this comment.
With this change it also becomes possible to return an immutable reference from the buf_as_slice_mut function on RDesRing and thus avoid triggering the clippy::mut_from_ref lint! That would be a nice simplification, and since RDesRing is private it wouldn't impact the external API
|
Thanks for the PR! Because smoltcp 0.12.0 is only compatible with rustc back to 1.80.0, you need to raise the MSRV of this crate to pass CI. There's a commit here that shows how to change the MSRV in both the README and the CI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.