Fixed an issue with auto_update in connection with structs #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ationAttrib is correctly set to _structure_size if a structure is present.
…ationAttrib is correctly set to _structure_size if a structure is present.
…ttps://github.com/msfur/pyads into feature/structure_support_for_device_notification
Pull Request Test Coverage Report for Build 11613228498Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Small Typo Fix (you plc -> your plc)
…ationAttrib is correctly set to _structure_size if a structure is present.
…ttps://github.com/msfur/pyads into feature/structure_support_for_device_notification
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #372 by adjusting
add_device_notification()to correctly set the length ofNotificationAttribto_structure_sizeif a structure is present. Thanks to @ascaron37 for reporting this.