add CI test for mass chart buttons #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xzhou82
changed the title
compbiolover
approved these changes
Jan 6, 2025
|
@xzhou82, I'm wondering if the tests for the chart buttons should really be e2e tests since we're checking click behavior. |
|
yes i agree to have a e2e version for the chart button clicking, especially for different ds each with its own customization. the current tests are hardcoded for termdbtest which is fine as CI, and are definitely needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
test link
plot sandbox is dynamically generated thus a data-testid is added for detection
chart button menu is persistent thus no testid is added
Checklist
Check each task that has been performed or verified to be not applicable.