This repository has been archived by the owner on Mar 29, 2022. It is now read-only.
[BUG#107] Ensure block should close connection only if using blocking subscription #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the subscription was created in a non-blocking fashion, this ensure block will be hit before the receiver was returned, rending the receiver unusable.
spilth
reviewed
Aug 2, 2021
Comment on lines
+51
to
+57
| # If the subscription was created in a non-blocking fashion, do not | ||
| # close the underlying connection before returning (or the receiver | ||
| # will not be usable). | ||
| # | ||
| # For more information, see here: | ||
| # | ||
| # https://github.com/stitchfix/pwwka/issues/107 |
There was a problem hiding this comment.
Is there a way we can express this comment as a test?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If the subscription was created in a non-blocking fashion, this ensure block will be hit before the receiver was returned, rending the receiver unusable. See #107 for more information.
Solution
The
ensureblock should close the underlying connection only if the subscription blocked (because the asynchronously-deliveredInterruptwould causeBunny::Queue#subscribeto unwind). Subscriptions created in a non-blocking fashion should allow callers to handle signal trapping and connection teardown themselves.