Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR (feature, enhancement, bug fix, etc.)
Description
Fixes the handling of
by making the following tradeoff:
Note: this is largely a revert of 69cb070
Fixes #652
Why should this be added
#652 is a hard to debug and is easy to run into e.g. when building an autocomplete search box. The real fix for the bug involves an upstream change to Nokogiri, but it's unclear when that will happen. I don't know if this is a good tradeoff or not - just thought I'd propose it as an alternative to #674.
Checklist