Fix ReflexData parsing #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The data in ReflexData was recently changed to transform all keys to underscored values without preserving the originals (like "data-reflex"), but this causes problems elsewhere (like missing attributes in element.dataset). Both sets of keys need to be present (see updated test setup).
✅ Deploy Preview for stimulusreflex ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
marcoroth
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Thank you @Matt-Yorkley! I'm wondering if there's an easy way how we can test this in a full-stack setup so the tests could catch another regression!
|
I had the same thought, a couple of full-stack tests would be great. Maybe a dummy app and some System Tests with Capybara/Cuprite is the way to go? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug Fix
Description
The data in
StimulusReflex::ReflexDatawas recently changed to transform all keys to underscored keys without preserving the original kebab-case keys (likedata-controller), but this causes breaking changes elsewhere in the codebase. Both sets of keys need to be preserved but this was missed by the relevant tests because the test input was using a plain hash instead of instantiating a ReflexData object (see updated test setup).Why should this be added
The previous change caused issues like missing attributes in
element.datasetin Reflexes. It's inmain, but it's not released yet.Checklist