Skip to content

Commit

Permalink
Add Thor Dependency And Require It
Browse files Browse the repository at this point in the history
Rake tasks were failing in projects because the
required Thor dependency was not listed in the
Gemspec file.

The fix also needed to explicitly require the thor
gem in the installer file that used it as a mixin.
  • Loading branch information
juna-nb committed May 24, 2024
1 parent 8d83a8f commit e1d16a4
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
6 changes: 5 additions & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ PATH
rack (>= 2, < 4)
railties (>= 5.2, < 8)
redis (>= 4.0, < 6.0)
thor (>= 1.3.1)

GEM
remote: https://rubygems.org/
Expand Down Expand Up @@ -125,6 +126,8 @@ GEM
net-smtp (0.3.3)
net-protocol
nio4r (2.5.8)
nokogiri (1.16.5-arm64-darwin)
racc (~> 1.4)
nokogiri (1.16.5-x86_64-darwin)
racc (~> 1.4)
nokogiri (1.16.5-x86_64-linux)
Expand Down Expand Up @@ -209,6 +212,7 @@ GEM
zeitwerk (2.6.13)

PLATFORMS
arm64-darwin-23
x86_64-darwin-19
x86_64-darwin-22
x86_64-darwin-23
Expand All @@ -225,4 +229,4 @@ DEPENDENCIES
stimulus_reflex!

BUNDLED WITH
2.4.14
2.5.6
2 changes: 2 additions & 0 deletions lib/stimulus_reflex/installer.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# frozen_string_literal: true

require "thor"

module StimulusReflex
class Installer
include Thor::Base
Expand Down
3 changes: 2 additions & 1 deletion stimulus_reflex.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,10 @@ Gem::Specification.new do |gem|

gem.add_dependency "cable_ready", "~> 5.0"
gem.add_dependency "nokogiri", "~> 1.0"
gem.add_dependency "nokogiri-html5-inference", "~> 0.3"
gem.add_dependency "rack", ">= 2", "< 4"
gem.add_dependency "redis", ">= 4.0", "< 6.0"
gem.add_dependency "nokogiri-html5-inference", "~> 0.3"
gem.add_dependency "thor", ">= 1.3.1"

gem.add_development_dependency "bundler", "~> 2.0"
gem.add_development_dependency "magic_frozen_string_literal", "~> 1.2"
Expand Down

0 comments on commit e1d16a4

Please sign in to comment.