Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rabbit-consumer source code #89

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

anish-mudaraddi
Copy link
Collaborator

move rabbit-consumer source code out of SCD-Openstack-Utils

@anish-mudaraddi anish-mudaraddi marked this pull request as draft January 3, 2025 12:14
move rabbit-consumer source code out of SCD-Openstack-Utils
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 96.92029% with 34 lines in your changes missing coverage. Please review.

Project coverage is 96.92%. Comparing base (312999b) to head (c8dad29).

Files with missing lines Patch % Lines
...penstack-rabbit-consumer/rabbit_consumer/aq_api.py 90.00% 14 Missing ⚠️
...abbit-consumer/rabbit_consumer/message_consumer.py 94.24% 8 Missing ⚠️
...bbit-consumer/rabbit_consumer/openstack_address.py 84.21% 6 Missing ⚠️
...k-rabbit-consumer/rabbit_consumer/openstack_api.py 88.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   96.62%   96.92%   +0.29%     
==========================================
  Files          13       16       +3     
  Lines         651     1104     +453     
==========================================
+ Hits          629     1070     +441     
- Misses         22       34      +12     
Flag Coverage Δ
rabbit_consumer 96.92% <96.92%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anish-mudaraddi anish-mudaraddi marked this pull request as ready for review January 7, 2025 09:27
@anish-mudaraddi anish-mudaraddi changed the title WIP: add rabbit-consumer source code add rabbit-consumer source code Jan 7, 2025
khalford
khalford previously approved these changes Jan 7, 2025
Copy link
Contributor

@meoflynn meoflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the PR has pushed duplicate staging images for our notebooks (as they are now in a new folder), we need to have a look at our existing images before this gets merged

@anish-mudaraddi
Copy link
Collaborator Author

anish-mudaraddi commented Jan 8, 2025

It looks like the PR has pushed duplicate staging images for our notebooks (as they are now in a new folder), we need to have a look at our existing images before this gets merged

So with this change the images are being saved to stfc-cloud-staging/notebooks/<image-name> instead of stfc-cloud-staging/<image-name>. It's going to be a lot of work to change and I think this naming convention is useful so I vote we keep it as is

This will require us to change any image references to match

@khalford
Copy link
Member

khalford commented Jan 8, 2025

It looks like the PR has pushed duplicate staging images for our notebooks (as they are now in a new folder), we need to have a look at our existing images before this gets merged

So with this change the images are being saved to stfc-cloud-staging/notebooks/<image-name> instead of stfc-cloud-staging/<image-name>. It's going to be a lot of work to change and I think this naming convention is useful so I vote we keep it as is

This will require us to change any image references to match

Alongside changing the image references it might also be worth deleting or archiving the current / previous groups as they will no longer be receiving new images

specify login to staging harbor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants