File restructure and Linting #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changed the package name to be more appropriate. And restructured the modules to be in correct directories.
Created a workflow to run pytests and pylint at pull request to master branch.
khalford
force-pushed
the
workflow
branch
2 times, most recently
from
40b335c to
d32f7e8
Compare
| @@ -23,7 +23,7 @@ def create_device(self, data: dict | list) -> bool: | |||
| return bool(devices) | |||
|
|
|||
| def create_device_type( | |||
| self, model: str, slug: str, manufacturer: str, u_height=1 | |||
| self, model: str, slug: str, manufacturer: str, u_height=1 | |||
There was a problem hiding this comment.
you forgot type hint for u_height
anish-mudaraddi
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructuring the Project. Linting all the files. Adding a workflow