Skip to content

Commit

Permalink
build(ci): reverts pnpm migration and exports REQUEST (#295)
Browse files Browse the repository at this point in the history
* build(ci): enable tests step in GitHub Actions CI workflow

* build(ci): enable tests step in GitHub Actions CI workflow

* build(ci): enable tests step in GitHub Actions CI workflow

* docs: updates README.md

* build(ci): Switch pnpm with npm due to issue with TS and SSR

This commit replaces `pnpm` with `npm` in the Github Actions workflows.

* build(ci): Switch pnpm with npm due to issue with TS and SSR

This commit replaces `pnpm` with `npm` in the Github Actions workflows.

* build(ci): Switch pnpm with npm due to issue with TS and SSR

This commit replaces `pnpm` with `npm` in the Github Actions workflows.
  • Loading branch information
pavankjadda authored Dec 8, 2023
1 parent 24dd075 commit 998011f
Show file tree
Hide file tree
Showing 8 changed files with 19,853 additions and 10,675 deletions.
13 changes: 5 additions & 8 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,22 +15,19 @@ jobs:
node: ['18']
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
with:
version: latest
- name: Use Node.js ${{ matrix.node }}
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node }}
- name: Install dependencies
run: pnpm install --frozen-lockfile
run: npm i
- name: Lint
run: pnpm lint
run: npm run lint
- name: Format check
run: pnpm format:check
run: npm run format:check
- name: Build
run: pnpm build --configuration=production && pnpm build:ngx-cookie-service-ssr --configuration=production
run: npm run build --configuration=production && npm run build:ngx-cookie-service-ssr --configuration=production
- name: Test
run: pnpm test
run: npm run test
env:
CI: true
7 changes: 2 additions & 5 deletions .github/workflows/npm_publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
with:
version: latest
- uses: actions/setup-node@v2
with:
node-version: 18
- name: Install NPM Dependencies
run: pnpm install --frozen-lockfile
run: npm i
- name: Build project
run: pnpm build --configuration=production
run: npm run build --configuration=production
- name: Publish to NPM
uses: JS-DevTools/npm-publish@v3
with:
Expand Down
9 changes: 3 additions & 6 deletions .github/workflows/npm_publish_ssr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,13 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- uses: pnpm/action-setup@v2
with:
version: latest
- uses: actions/setup-node@v2
with:
node-version: 18
- name: Install PNPM Dependencies
run: pnpm install --frozen-lockfile
- name: Install NPM Dependencies
run: npm i
- name: Build project
run: pnpm build:ngx-cookie-service-ssr
run: npm run build:ngx-cookie-service-ssr
- name: Publish to NPM registry
uses: JS-DevTools/npm-publish@v3
with:
Expand Down
2 changes: 1 addition & 1 deletion .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ dist
.angular
.github
README.md
pnpm-lock.yaml
package-lock.json
7 changes: 2 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ import {CookieService} from 'ngx-cookie-service';

@NgModule({
...
providers:
[CookieService],
providers:[CookieService],
...
})

Expand All @@ -50,9 +49,7 @@ export class AppModule {
Then, import and inject it into a constructor:

```typescript
constructor(private
cookieService: CookieService
)
constructor(private cookieService: CookieService)
{
this.cookieService.set('Test', 'Hello World');
this.cookieValue = this.cookieService.get('Test');
Expand Down
Loading

0 comments on commit 998011f

Please sign in to comment.