Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only use the previewwindow if requested by the user #532

Merged

Conversation

GustavoKatel
Copy link
Contributor

@GustavoKatel GustavoKatel commented Dec 8, 2024

Tentative fix for #524

closes #524

@github-actions github-actions bot requested a review from stevearc December 8, 2024 18:18
@GustavoKatel GustavoKatel marked this pull request as ready for review December 8, 2024 18:19
Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the correct approach to fix the issue, but why did you remove the calls to update_preview_window? I'm pretty sure that will lead to out-of-date previews in some cases.

@GustavoKatel GustavoKatel force-pushed the better-handling-previewwindow branch from 09eb34a to df7043a Compare December 9, 2024 11:50
@github-actions github-actions bot requested a review from stevearc December 9, 2024 11:50
@GustavoKatel
Copy link
Contributor Author

but why did you remove the calls to update_preview_window?

late night coding. my bad :) fixed it

@GustavoKatel GustavoKatel force-pushed the better-handling-previewwindow branch from df7043a to fb6c357 Compare December 11, 2024 17:46
@stevearc
Copy link
Owner

Thanks for the PR!

@stevearc stevearc merged commit 78ab7ca into stevearc:master Dec 21, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Oil is hijacking the preview window on open
2 participants