fix: set alternate when using floating windows (#285)

[iovis]

This ensures the alternate is set even when using open_float(), I copied the code from restore_alt_buf, so I'm sure there could be refactor opportunities. Let me know your thoughts!

Fixes: #285

[stevearc]

Everything related to the alternate buffer is very tricky. Please add at least one test to cover this case in https://github.com/stevearc/oil.nvim/blob/master/tests/altbuf_spec.lua. Make sure that it fails without your change applied and passes with it.

[iovis]

I completely missed the tests, my bad. I'll give it a go tonight!

[iovis]

Done, sorry for missing the tests! I confirmed the new test fails in master but passes on my branch.

[stevearc]

Thanks for adding the test! I fiddled with it a bit on my end, and I think that a simpler fix is to remove the keepalt = true on this line.

oil.nvim/lua/oil/init.lua

Line 721 in 7a55ede

keepalt = true,

That handles the float win case for me, and doesn't seem to impact any of the other tests.

[iovis]

Thanks for adding the test! I fiddled with it a bit on my end, and I think that a simpler fix is to remove the keepalt = true on this line.

You're right, I can confirm it works on my end and it looks like a much more appropriate fix. I just sent the revised code!

[stevearc]

Something strange going on with the test failures in 0.8. I'll investigate when I get a chance

[iovis]

I think I found the issue in v0.8, when I removed keepalt completely, then this table:

-- lua/oil/init.lua:717
local mods = {                  
  vertical = opts.vertical,     
  horizontal = opts.horizontal, 
  split = opts.split,           
}                               

could result in an empty table, which apparently neovim v0.8 doesn't like:

Error executing vim.schedule lua callback: ~/code/vim/oil.nvim/lua/oil/init.lua:745: 'mods' must be a Dictionary
stack traceback:
        [C]: in function 'cmd'
        ~/code/vim/oil.nvim/lua/oil/init.lua:745: in function 'callback'
        ~/code/vim/oil.nvim/lua/oil/adapters/files.lua:260: in function ''
        vim/_editor.lua: in function <vim/_editor.lua:0>

Changing it from removing it completely to keepalt = false resolves the issue and the tests still pass (which I cleaned up a bit).

[stevearc]

Great, thanks for the fix!

[tjex]

Thank you so much for this everyone!!!!