Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable preview for large files #511

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

stevalkr
Copy link
Contributor

@stevalkr stevalkr commented Nov 8, 2024

Hi, I’ve made a small change to prevent nvim session from freezing when previewing large files.

Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good, but I've had to refactor a bunch of the config names recently to reduce confusion. You'll need to rebase to resolve the merge conflicts.

README.md Outdated Show resolved Hide resolved
@stevalkr stevalkr force-pushed the disable_preview_for_large_files branch from 7b426ba to a735e8a Compare November 11, 2024 12:46
@github-actions github-actions bot requested a review from stevearc November 11, 2024 12:47
@stevalkr stevalkr force-pushed the disable_preview_for_large_files branch from 97fb744 to ec610ea Compare November 11, 2024 12:52
@stevearc
Copy link
Owner

typechecking errors. If you have LuaLS installed you can run make lint to view to run it locally

@stevalkr
Copy link
Contributor Author

Sorry about that, I didn’t check all the changes thoroughly. Should be all good now.

fix: update oil.PreviewWindowConfig
@stevalkr stevalkr force-pushed the disable_preview_for_large_files branch from 473023f to 15a4a43 Compare November 12, 2024 09:13
@stevearc
Copy link
Owner

Thanks for the PR!

@stevearc stevearc merged commit c23fe08 into stevearc:master Nov 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants