Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Customisability for floating window title. #482

Merged
merged 19 commits into from
Oct 16, 2024
Merged

Adding Customisability for floating window title. #482

merged 19 commits into from
Oct 16, 2024

Conversation

PhilippOesch
Copy link
Contributor

Add support to display the window title relative to the current working directory. See #382

@github-actions github-actions bot requested a review from stevearc September 15, 2024 14:38
@PhilippOesch PhilippOesch marked this pull request as ready for review September 16, 2024 20:37
@PhilippOesch PhilippOesch marked this pull request as draft September 19, 2024 02:05
@PhilippOesch PhilippOesch changed the title Feature/diplaye relative path in floating window title Adding Customizability for floating window title. Sep 19, 2024
@PhilippOesch PhilippOesch changed the title Adding Customizability for floating window title. Adding Customisability for floating window title. Sep 19, 2024
stevearc
stevearc requested changes Oct 6, 2024
View reviewed changes
Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a reasonable extension to the configurability. Left a couple notes for small changes.

lua/oil/util.lua Outdated Show resolved Hide resolved
lua/oil/util.lua Outdated Show resolved Hide resolved
lua/oil/config.lua Outdated Show resolved Hide resolved
@github-actions github-actions bot requested a review from stevearc October 12, 2024 21:30
@PhilippOesch PhilippOesch marked this pull request as ready for review October 15, 2024 18:06
@stevearc
Copy link
Owner

Looks good, thanks for the PR!

@stevearc stevearc merged commit 5d2dfae into stevearc:master Oct 16, 2024
10 checks passed
@github-actions github-actions bot mentioned this pull request Oct 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevearc stevearc Awaiting requested review from stevearc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PhilippOesch @stevearc