feat: improve is_modifiable checks for unix os's #428
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
This will resolve #342, it improves the
is_modifiable
function for directories on unix systems by more accurately checking whether the user has write permission for the directory.This PR changes the function so that it:
id -G
command (gets all gid's of groups that the user is in) and checking if directory gid is in this list.Questions
id -G
is independent of directories (based on the nvim process user), I just added an extra variable to the cache module with functions to get and set it.