Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot perform file/directory operations within LSP workspaces #411

Merged
merged 1 commit into from
Jun 11, 2024
Merged

fix: cannot perform file/directory operations within LSP workspaces #411

merged 1 commit into from
Jun 11, 2024

Conversation

namvnngu
Copy link
Contributor

@namvnngu namvnngu commented Jun 11, 2024

Hi @stevearc,

This is my very first PR to contribute to the most favorite plugin that I cannot live without. I raise a PR to fix the issue #410.
The root cause of the issue is that the plugin called vim.has("nvim-0.11") instead of vim.fn.has("nvim-0.11") in the file lua/oil/lsp/workspace.lua.

I would really appreciate if you can review my PR.

Thank you so much.

@github-actions github-actions bot requested a review from stevearc June 11, 2024 06:42
@namvnngu namvnngu changed the title Fix: Cannot perform file/directory operations within workspaces that have LSP running Fix: cannot perform file/directory operations within workspaces that have LSP running Jun 11, 2024
@namvnngu namvnngu changed the title Fix: cannot perform file/directory operations within workspaces that have LSP running fix: cannot perform file/directory operations within LSP workspaces Jun 11, 2024
@RVxLab
Copy link

RVxLab commented Jun 11, 2024

@namvnngu I can confirm your fix worked on 0.10 stable, much appreciated!

@namvnngu
Copy link
Contributor Author

namvnngu commented Jun 11, 2024

@namvnngu I can confirm your fix worked on 0.10 stable, much appreciated!

@RVxLab Thanks for your confirmation.

@stevearc
Copy link
Owner

Thanks for the fix!

@stevearc stevearc merged commit 61f1967 into stevearc:master Jun 11, 2024
9 checks passed
@namvnngu namvnngu deleted the cannot-perform-file-directory-operations-within-workspaces-that-have-lsp-running branch June 11, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants