Escape all paths for ssh file changes using vim.fn.shellescape()
#353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevearc
requested changes
Apr 17, 2024
There was a problem hiding this comment.
Agree that we need to escape the paths, but the problem with shellescape is that its behavior depends on the local platform. So this won't work at all if your local machine is windows, for example. Helpfully, the ssh adapter only supports remote machines with /bin/sh, so we don't have to handle multiple types of escaping.
I think we should use our own escaping logic. I believe a simple find and replace of ' with '\'' followed by wrapping the entire string in '' should do it.
Really, only escape `'` with `'\\''` so that it will: - exit the single quote mode - escape out a single quote character - and get back into the single quote mode Also format long line so linter doesn't complain
|
Done. I've also fixed the linting error while I was at it |
|
Awesome, thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #352.
At least it works on my own machines.