feat: add ability to alter lsp file operation timeout #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevearc
requested changes
Mar 2, 2024
lua/oil/config.lua
Outdated
Comment on lines
43
to
46
|
|
||
| -- The amount of time LSP waits for file operation before it errors | ||
| lsp_file_operation_timeout_ms = 1000, | ||
|
|
There was a problem hiding this comment.
Since we're adding another option related to LSP file operations (and we may want more in the future), let's nest this under another table
lsp_file_methods = {
timeout_ms = 1000
}We'll also want to move lsp_rename_autosave into that table with a backwards compatibility shim and deprecation message, but I can do that after this PR.
Would also recommend rewording the comment to something like "Time to wait for LSP file operations to complete before skipping" to make it clear that we're waiting on the LSP, and that the consequences of a timeout are only that it gets skipped.
There was a problem hiding this comment.
Hi @stevearc, I tried to do all of the above. Let me know if there is anything else I need to change. Thank you!
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a large repo in typescript where 1000ms is not enough time for LSP to resolve my rename file request. Therefore, I want to add a config that allows the user to alter the timeout, while keeping the default of 1000ms