feat: add didRename
LSP notification support
#260
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to the built-in
willRename
LSP client integration, this adds in built-indidRename
support. This includes a couple refactors of some internal functions as well as making sure that only successful move operations are communicated in thedidRename
notification.So far I have tested to make sure this works with both
vtsls
andluals
which provide import/require updates ondidRename
and it works great. I have also verified that the oldwillRename
support has not broken by testing withtsserver
.Resolves #259
Here are the LSP spec references used in making this:
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_didRename
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#workspace_didRenameFiles