Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cleanup delay configurable #191

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Make cleanup delay configurable #191

merged 1 commit into from
Oct 3, 2023

Conversation

vE5li
Copy link
Contributor

@vE5li vE5li commented Oct 1, 2023

Currently oil buffers will always stay open until 2 seconds after they are not visible anymore, but that behavior can be problematic if you want to go back to the previous file using Ctrl+O.

I found myself constantly jumping back to the oil buffer instead of the previous file on accident, similarly some people might like this delay to be longer because they want to jump back to the oil buffer.

This PR aims to make the delay configurable. A delay of zero will cause the buffers to close instantly, resulting in behavior closer to telescope, while any other number will be taken as the delay in milliseconds. The default remains 2 seconds, so this is a backwards compatible change.

Copy link
Owner

@stevearc stevearc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great idea and honestly something I should have done a while ago. Just a couple small requests about phrasing and behavior

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@vE5li vE5li changed the title Make close delay configurable Make cleanup delay configurable Oct 2, 2023
@stevearc
Copy link
Owner

stevearc commented Oct 3, 2023

Looks great, thanks for sticking with it through the iterations!

@stevearc stevearc merged commit a9f7f69 into stevearc:master Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants