Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add To Launcher Button for Stereum Servers #2136

Merged
merged 12 commits into from
Dec 15, 2024
Merged

Add To Launcher Button for Stereum Servers #2136

merged 12 commits into from
Dec 15, 2024

Conversation

MaxTheGeeek
Copy link
Contributor

@MaxTheGeeek MaxTheGeeek commented Dec 5, 2024 •
edited
Loading

Description

Add "Add To Launcher" button that enables users to import purchased servers from the web app directly into the Stereum Launcher with a single click.

Technical Implementation

  • Implemented custom URL protocol handler (stereumlauncher://)
  • Added protocol handling for all platforms (Windows, macOS, Linux)
  • Created server data import functionality
  • Added server validation and duplicate checking

Features

  • One-click server import from web to desktop app
  • Automatic launcher opening
  • Server data validation
  • Duplicate server detection
  • Cross-platform support

Testing Status

  • macOS: Tested and working
  • Windows: Tested and working
  • Linux: Tested and working

@MaxTheGeeek MaxTheGeeek marked this pull request as draft December 5, 2024 12:32
@MaxTheGeeek
Copy link
Contributor Author

Thoroughly tested and confirmed to work seamlessly on macOS, Windows, and Linux. It successfully opens the application and handles protocol data as expected across all platforms 🔥🚀😊

@MaxTheGeeek MaxTheGeeek requested a review from M4r71nW December 12, 2024 11:23
@MaxTheGeeek MaxTheGeeek marked this pull request as ready for review December 12, 2024 13:39
NeoPlays
NeoPlays requested changes Dec 13, 2024
View reviewed changes
Copy link
Member

@NeoPlays NeoPlays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise 🚀

launcher/src/background.js Show resolved Hide resolved
@daGscheid daGscheid merged commit 2876801 into stereum-dev:main Dec 15, 2024
4 checks passed
@daGscheid daGscheid mentioned this pull request Dec 15, 2024
Closed
3 tasks
@MaxTheGeeek MaxTheGeeek deleted the add_to_launcher branch December 18, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NeoPlays NeoPlays NeoPlays approved these changes

@gbayasgalan gbayasgalan Awaiting requested review from gbayasgalan

@daverolo daverolo Awaiting requested review from daverolo

@M4r71nW M4r71nW Awaiting requested review from M4r71nW

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MaxTheGeeek @NeoPlays @gbayasgalan @daGscheid