Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: Obol Alerts #2018

Merged
merged 15 commits into from
Sep 3, 2024
Merged

ADD: Obol Alerts #2018

merged 15 commits into from
Sep 3, 2024

Conversation

NeoPlays
Copy link
Member

@NeoPlays NeoPlays commented Aug 28, 2024

This PR adds Alerts for Grafana as well as Stereum for Obols Charon Client.

ToDo:

  • Function which fetches metrics and evaluates
  • Provision Alerts for Grafana
  • Frontend which displays the Alerts returned from this function (refresh every 2 mins and on mount) @mabasian

@NeoPlays NeoPlays linked an issue Aug 28, 2024 that may be closed by this pull request
1 task
@NeoPlays NeoPlays marked this pull request as ready for review September 2, 2024 11:20
mabasian
mabasian previously approved these changes Sep 2, 2024
Copy link
Contributor

@mabasian mabasian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NeoPlays NeoPlays dismissed mabasian’s stale review September 2, 2024 12:38

The merge-base changed after approval.

@mabasian mabasian self-requested a review September 3, 2024 08:35
@NeoPlays NeoPlays requested a review from M4r71nW September 3, 2024 08:39
@NeoPlays NeoPlays dismissed gbayasgalan’s stale review September 3, 2024 08:45

The merge-base changed after approval.

gbayasgalan
gbayasgalan previously approved these changes Sep 3, 2024
Copy link
Contributor

@gbayasgalan gbayasgalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

mabasian
mabasian previously approved these changes Sep 3, 2024
M4r71nW
M4r71nW previously approved these changes Sep 3, 2024
@NeoPlays NeoPlays dismissed stale reviews from M4r71nW and mabasian September 3, 2024 08:50

The merge-base changed after approval.

@NeoPlays NeoPlays marked this pull request as draft September 3, 2024 08:52
@NeoPlays NeoPlays marked this pull request as ready for review September 3, 2024 08:52
@NeoPlays NeoPlays merged commit f17d1a9 into stereum-dev:main Sep 3, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Obol Cluster Alerts in Stereum
4 participants