Static Class and Helper Functions #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te the base58_encode and base58_decode functions.
| @@ -0,0 +1,33 @@ | |||
| <?php | |||
|
|
|||
| if (false === function_exists('base58_encode')) | |||
There was a problem hiding this comment.
No need in false ===, it looks weird. I think
if (!function_exists('base58_encode'))
Is 100% enough and much more readable :)
|
Also I think there should be some usage example in README.md. In common, looks great! 👍 |
…ed to add unit tests for these methods.
document methods and add unit tests.
|
You shouldn't really define these functions in the global namespace. Put them in the use function StephenHill\base58_encode;
use function StephenHill\base58_decode; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the following classes:
and adds the following functions:
This pull request is directly related to issue #14.
The master branch will be tagged with v1.2 when this branch is merged.
Still todo is document the changes in readme.md.