Skip to content

Commit

Permalink
Only run the backport job on merged pull requests (opensearch-project…
Browse files Browse the repository at this point in the history
…#3134)

### Description
Only run the backport job on merged pull requests

### Issues Resolved
From the GitHub Action log, we'd see an error about branch_name not
being used, and the error that backports should only run on merged PRs.
This should reduce noisy failures in our logs.
```
Warning: Unexpected input(s) 'branch_name', valid inputs are ['body_template', 'files_to_skip', 'github_token', 'head_template', 'label_pattern', 'labels_template', 'title_template', 'failure_labels']
Run VachaShah/backport@v[2](https://github.com/opensearch-project/security/actions/runs/5802658423/job/15729398925?pr=3132#step:3:2).2.0
Error: Error: For security reasons, this action should only run on merged PRs.
```
Example [[workflow
failure]](https://github.com/opensearch-project/security/actions/runs/5802658423/job/15729398925?pr=3132),
see more
[[failures]](https://github.com/opensearch-project/security/actions/workflows/backport.yml).


### Check List
- [ ] ~New functionality includes testing~
- [ ] ~New functionality has been documented~
- [X] Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and
signing off your commits, please check
[here](https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin).

Signed-off-by: Peter Nied <[email protected]>
  • Loading branch information
peternied authored Aug 9, 2023
1 parent f77cc03 commit 5f7efa5
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/backport.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ on:

jobs:
backport:
if: github.event.pull_request.merged == true
runs-on: ubuntu-latest
permissions:
contents: write
Expand All @@ -25,6 +26,5 @@ jobs:
uses: VachaShah/[email protected]
with:
github_token: ${{ steps.github_app_token.outputs.token }}
branch_name: backport/backport-${{ github.event.number }}
head_template: backport/backport-<%= number %>-to-<%= base %>
failure_labels: backport-failed

0 comments on commit 5f7efa5

Please sign in to comment.