Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add indices_threshold function #73

Merged
merged 2 commits into from
Oct 23, 2024

Conversation

Pringled
Copy link
Collaborator

This PR adds an indices_threshold function that returns unsorted indices above a threshold, a faster alternative to nearest_neighbors_threshold if you don't need sorted results.

@Pringled Pringled requested a review from stephantul October 18, 2024 19:12
Copy link
Owner

@stephantul stephantul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small comments. I see two paths forward:

  1. also make a most_similar version
  2. collapse the helper function into the body of the main function you added.

I'm a bigger fan of 2). I don't think anyone would use it.

reach/reach.py Outdated Show resolved Hide resolved
reach/reach.py Outdated Show resolved Hide resolved
reach/reach.py Outdated Show resolved Hide resolved
reach/reach.py Outdated Show resolved Hide resolved
tests/test_similarity.py Outdated Show resolved Hide resolved
reach/reach.py Show resolved Hide resolved
reach/reach.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants