Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made some more fields optional #391

Merged

Conversation

quotschmacher
Copy link
Contributor

No description provided.

@quotschmacher
Copy link
Contributor Author

According to validator results

image

@stephanstapel
Copy link
Owner

Please also mind this:

grafik

@quotschmacher
Copy link
Contributor Author

quotschmacher commented Oct 10, 2024

CountrySubsidenty - BT-39 - so this should be CountrySubdivisionName,
AddressLine - BT-162 - so this should be AddressLine3 which is mapped to AdditionalStreetName, which is BT-36. BT-36 is not commented in the Party-Model so and I could not find it.

  • AdditionalStreetName - BT-36 - ??
  • CountrySubsidenty - BT-39 - Party.CountrySubdivisionName
  • AddressLine:Line - BT-162 - Party.AddressLine3

Correct?

@quotschmacher
Copy link
Contributor Author

The description https://portal3.gefeg.com/projectdata/invoice/deliverables/installed/publishingproject/xrechnung%202.1.1%20-%20(ab%2001.02.2022)/xrechnung_ubl_invoice_v2.1.1_01.02.2022.scm/html/de/0272.htm states
AddressLine No

AddressLine No 1 - StreetName (BT-35 / BT-50)
AddressLine No 2 - AdditionalStreetName (BT-36 / BT-51)
AddressLine No 3 - AddressLine:Line (BT-162 / BT-163)

this is what the cii-writer is doing:

                writer.WriteOptionalElementString("ram:LineOne", string.IsNullOrWhiteSpace(party.ContactName) ? party.Street : party.ContactName); // buyer: BT-50
                if (!string.IsNullOrWhiteSpace(party.ContactName)) { writer.WriteOptionalElementString("ram:LineTwo", party.Street); } // buyer: BT-51
                writer.WriteOptionalElementString("ram:LineThree", party.AddressLine3); // buyer: BT-163

@stephanstapel stephanstapel merged commit c86e4ee into stephanstapel:master Oct 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants