Fix SpecifiedLegalOrganization profile

[danvy]

SpecifiedLegalOrganization was missing in some profiles

[stephanstapel]

Good morning,

thanks for the pull request. I'm not sure if this is correct either.
From the docs (ZUGFeRD 2.2, i.e. excluding XRechnung specification):

TradingBusinessName:

SpecifiedLegalOrganization:

[danvy]

In the lastest Factur-X doc, SpecifiedLegalOrganization is introduced in the BASCI WL profile.
I let you decide for XRechnung.
This is a severe issue for us as documents are being rejected.

[stephanstapel]

ok, thanks. For me to remember later - according to version 1.0.6, SpecifiedLegalOrganization is handled like:

ShipToTradeParty, ShipFromTradeParty, SalesAgentTradeParty, UltimateShipToTradeParty, BuyerTaxRepresentativeTradeParty, ProductEndUserTradeParty, BuyerAgentTradeParty, InvoicerTradeParty, InvoiceeTradeParty, PayerTradeParty:

SellerTradeParty, BuyerTradeParty, PayeeTradeParty:

[stephanstapel]

TradingBusinessName:

BuyerTradeParty

ShipToTradeParty, SalesAgentTradeParty, BuyerTaxRepresentativeTradeParty, SellerTaxRepresentativeTradeParty, ProductEndUserTradeParty, ...:

SellerTradeParty, PayeeTradeParty:

BuyerTradeParty:

I have no idea why it has been designed like this though...

[danvy]

@stephanstapel Are you ok if I add includeLegalOrganization parameter to _writeOptionalParty and set its value on each call accordingly ?

[stephanstapel]

Imho the change is quite big. As written in my notes above, the necessity to write SpecifiedLegalOrganization differs from party to party. Probably, _WriteOptionalParty() needs to be rewritten to allow this. Do you have ideas for this?

[stephanstapel]

can you please add test cases?

[stephanstapel]

@danvy : besides the test cases (added one here:

ZUGFeRD-csharp/ZUGFeRD-Test/ZUGFeRD21Tests.cs

Line 210 in 695c92d

public void TestMinimumInvoice()

btw), can you please verify that this modification of your code:

695c92d

works as expected?

[danvy]

Could you push a new release so I can test IRL ?

[stephanstapel]

done