Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling limits #106

Merged
merged 7 commits into from
Jul 26, 2024
Merged

Allow disabling limits #106

merged 7 commits into from
Jul 26, 2024

Conversation

stephane-caron
Copy link
Owner

@stephane-caron stephane-caron commented Jul 24, 2024

This PR follows from this comment.

@coveralls
Copy link

coveralls commented Jul 24, 2024

Pull Request Test Coverage Report for Build 10098350690

Details

  • 23 of 23 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.002%) to 99.079%

Totals Coverage Status
Change from base Build 10098182798: 0.002%
Covered Lines: 1828
Relevant Lines: 1845

💛 - Coveralls

@stephane-caron
Copy link
Owner Author

stephane-caron commented Jul 24, 2024

@domrachev03 @simeon-ned FYI, this PR makes limits similar to tasks. Users will be able to disable them too if they want (by setting limits=[]).

Since we are about to release Pink v3 I'd rather make this API update now. Feel free to share your thoughts.

I also have one question: in barriers there is a compute_qp_inequality but in the rest of the library we call it compute_qp_inequalities. I think we should use the same name for consistency (o/w developers will have to remember which one is singular and which one is plural). I chose "inequalities" before to highlight that there are many of them, but I don't have a strong preference. Do you have an opinion on this?

@stephane-caron stephane-caron marked this pull request as ready for review July 24, 2024 07:43
@simeon-ned
Copy link
Contributor

@stephane-caron I think providing limits as you have done in this PR is a clearer way, also I would prefer to have compute_qp_inequalities as it was before we introduced barriers.

@stephane-caron stephane-caron merged commit 462839b into main Jul 26, 2024
9 checks passed
@stephane-caron stephane-caron deleted the update/limits branch July 26, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants