Skip to content

Commit

Permalink
Conservative ICNS (velocity equation) (Exawind#628)
Browse files Browse the repository at this point in the history
* changing the icns formulation to be conservative. will cause reg test diffs, but has been evaluated in a variety of ABL simulations and is necessary for going forward with multiphase.

* Updating a comment and implementing the icns iconserv flag as an input parameter. Default is (now) conservative.
  • Loading branch information
mbkuhn authored Jun 30, 2022
1 parent 2513bb3 commit f9263e2
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions amr-wind/equation_systems/icns/icns_advection.H
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,10 @@ struct AdvectionOp<ICNS, fvm::Godunov>
godunov_scheme = godunov::scheme::PPM;
}

// TODO: Need iconserv flag to be adjusted???
iconserv.resize(ICNS::ndim, 0);
// Formulation of discrete ICNS equation
// 1 = conservative (default), 0 = nonconservative
pp.query("icns_conserv", m_cons);
iconserv.resize(ICNS::ndim, m_cons);
}

void preadvect(const FieldState fstate, const amrex::Real dt)
Expand Down Expand Up @@ -350,6 +352,7 @@ struct AdvectionOp<ICNS, fvm::Godunov>
godunov::scheme godunov_scheme = godunov::scheme::PPM;
std::string godunov_type;
bool godunov_use_forces_in_trans{false};
int m_cons{1};
};

/** MOL scheme for ICNS
Expand Down

0 comments on commit f9263e2

Please sign in to comment.