Fix readability-const-return-type in headers. (Exawind#588)

stephan-rohr · Mar 12, 2022 · a41e516 · a41e516
1 parent 544f81c
commit a41e516
Show file tree

Hide file tree

Showing 66 changed files with 66 additions and 66 deletions.
diff --git a/amr-wind/core/MeshMap.H b/amr-wind/core/MeshMap.H
@@ -30,7 +30,7 @@ class CFDSim;
 class MeshMap : public Factory<MeshMap>
 {
 public:
-    static const std::string base_identifier() { return "MeshMap"; }
+    static std::string base_identifier() { return "MeshMap"; }
 
     ~MeshMap() override = default;
 

diff --git a/amr-wind/core/Physics.H b/amr-wind/core/Physics.H
@@ -59,7 +59,7 @@ public:
 class Physics : public Factory<Physics, CFDSim&>
 {
 public:
-    static const std::string base_identifier() { return "Physics"; }
+    static std::string base_identifier() { return "Physics"; }
 
     ~Physics() override = default;
 

diff --git a/amr-wind/core/ViewField.H b/amr-wind/core/ViewField.H
@@ -31,7 +31,7 @@ public:
     ViewField(ViewField&&) = default;
     ViewField& operator=(ViewField&&) = default;
 
-    inline const std::string name() const { return m_src.name() + "view"; }
+    inline std::string name() const { return m_src.name() + "view"; }
 
     //! Number of components in this subview
     inline int num_comp() const { return m_ncomp; }

diff --git a/amr-wind/equation_systems/SourceTerm.H b/amr-wind/equation_systems/SourceTerm.H
@@ -18,7 +18,7 @@ namespace pde {
 class SourceTerm : public Factory<SourceTerm, const CFDSim&>
 {
 public:
-    static const std::string base_identifier() { return "SourceTerm"; }
+    static std::string base_identifier() { return "SourceTerm"; }
 
     ~SourceTerm() override = default;
 

diff --git a/amr-wind/equation_systems/density/DensitySource.H b/amr-wind/equation_systems/density/DensitySource.H
@@ -16,7 +16,7 @@ namespace pde {
 class DensitySource : public Factory<DensitySource, const CFDSim&>
 {
 public:
-    static const std::string base_identifier() { return "DensitySource"; }
+    static std::string base_identifier() { return "DensitySource"; }
 
     ~DensitySource() override = default;
 

diff --git a/amr-wind/equation_systems/icns/MomentumSource.H b/amr-wind/equation_systems/icns/MomentumSource.H
@@ -21,7 +21,7 @@ namespace pde {
 class MomentumSource : public Factory<MomentumSource, const CFDSim&>
 {
 public:
-    static const std::string base_identifier() { return "MomentumSource"; }
+    static std::string base_identifier() { return "MomentumSource"; }
 
     ~MomentumSource() override = default;
 

diff --git a/amr-wind/equation_systems/icns/source_terms/ABLForcing.H b/amr-wind/equation_systems/icns/source_terms/ABLForcing.H
@@ -16,7 +16,7 @@ namespace icns {
 class ABLForcing : public MomentumSource::Register<ABLForcing>
 {
 public:
-    static const std::string identifier() { return "ABLForcing"; }
+    static std::string identifier() { return "ABLForcing"; }
 
     explicit ABLForcing(const CFDSim& sim);
 

diff --git a/amr-wind/equation_systems/icns/source_terms/ABLMeanBoussinesq.H b/amr-wind/equation_systems/icns/source_terms/ABLMeanBoussinesq.H
@@ -19,7 +19,7 @@ namespace icns {
 class ABLMeanBoussinesq : public MomentumSource::Register<ABLMeanBoussinesq>
 {
 public:
-    static const std::string identifier() { return "ABLMeanBoussinesq"; }
+    static std::string identifier() { return "ABLMeanBoussinesq"; }
 
     explicit ABLMeanBoussinesq(const CFDSim& sim);
 

diff --git a/amr-wind/equation_systems/icns/source_terms/BodyForce.H b/amr-wind/equation_systems/icns/source_terms/BodyForce.H
@@ -17,7 +17,7 @@ namespace icns {
 class BodyForce : public MomentumSource::Register<BodyForce>
 {
 public:
-    static const std::string identifier() { return "BodyForce"; }
+    static std::string identifier() { return "BodyForce"; }
 
     explicit BodyForce(const CFDSim&);
 

diff --git a/amr-wind/equation_systems/icns/source_terms/BoussinesqBuoyancy.H b/amr-wind/equation_systems/icns/source_terms/BoussinesqBuoyancy.H
@@ -18,7 +18,7 @@ namespace icns {
 class BoussinesqBuoyancy : public MomentumSource::Register<BoussinesqBuoyancy>
 {
 public:
-    static const std::string identifier() { return "BoussinesqBuoyancy"; }
+    static std::string identifier() { return "BoussinesqBuoyancy"; }
 
     explicit BoussinesqBuoyancy(const CFDSim& sim);
 

diff --git a/amr-wind/equation_systems/icns/source_terms/CoriolisForcing.H b/amr-wind/equation_systems/icns/source_terms/CoriolisForcing.H
@@ -15,7 +15,7 @@ namespace icns {
 class CoriolisForcing : public MomentumSource::Register<CoriolisForcing>
 {
 public:
-    static const std::string identifier() { return "CoriolisForcing"; }
+    static std::string identifier() { return "CoriolisForcing"; }
 
     explicit CoriolisForcing(const CFDSim&);
 

diff --git a/amr-wind/equation_systems/icns/source_terms/DensityBuoyancy.H b/amr-wind/equation_systems/icns/source_terms/DensityBuoyancy.H
@@ -21,7 +21,7 @@ namespace icns {
 class DensityBuoyancy : public MomentumSource::Register<DensityBuoyancy>
 {
 public:
-    static const std::string identifier() { return "DensityBuoyancy"; }
+    static std::string identifier() { return "DensityBuoyancy"; }
 
     explicit DensityBuoyancy(const CFDSim& sim);
 

diff --git a/amr-wind/equation_systems/icns/source_terms/GeostrophicForcing.H b/amr-wind/equation_systems/icns/source_terms/GeostrophicForcing.H
@@ -14,7 +14,7 @@ namespace icns {
 class GeostrophicForcing : public MomentumSource::Register<GeostrophicForcing>
 {
 public:
-    static const std::string identifier() { return "GeostrophicForcing"; }
+    static std::string identifier() { return "GeostrophicForcing"; }
 
     explicit GeostrophicForcing(const CFDSim&);
 

diff --git a/amr-wind/equation_systems/icns/source_terms/GravityForcing.H b/amr-wind/equation_systems/icns/source_terms/GravityForcing.H
@@ -14,7 +14,7 @@ namespace icns {
 class GravityForcing : public MomentumSource::Register<GravityForcing>
 {
 public:
-    static const std::string identifier() { return "GravityForcing"; }
+    static std::string identifier() { return "GravityForcing"; }
 
     explicit GravityForcing(const CFDSim& sim);
 

diff --git a/amr-wind/equation_systems/icns/source_terms/SynthTurbForcing.H b/amr-wind/equation_systems/icns/source_terms/SynthTurbForcing.H
@@ -13,7 +13,7 @@ namespace icns {
 class SynthTurbForcing : public MomentumSource::Register<SynthTurbForcing>
 {
 public:
-    static const std::string identifier() { return "SynthTurbForcing"; }
+    static std::string identifier() { return "SynthTurbForcing"; }
 
     explicit SynthTurbForcing(const CFDSim&);
 

diff --git a/amr-wind/equation_systems/sdr/SDRSource.H b/amr-wind/equation_systems/sdr/SDRSource.H
@@ -21,7 +21,7 @@ namespace pde {
 class SDRSource : public Factory<SDRSource, const CFDSim&>
 {
 public:
-    static const std::string base_identifier() { return "SDRSource"; }
+    static std::string base_identifier() { return "SDRSource"; }
 
     ~SDRSource() override = default;
 

diff --git a/amr-wind/equation_systems/sdr/source_terms/SDRSrc.H b/amr-wind/equation_systems/sdr/source_terms/SDRSrc.H
@@ -15,7 +15,7 @@ namespace tke {
 class SDRSrc : public SDRSource::Register<SDRSrc>
 {
 public:
-    static const std::string identifier() { return "SDRSrc"; }
+    static std::string identifier() { return "SDRSrc"; }
 
     explicit SDRSrc(const CFDSim&);
 

diff --git a/amr-wind/equation_systems/temperature/TemperatureSource.H b/amr-wind/equation_systems/temperature/TemperatureSource.H
@@ -21,7 +21,7 @@ namespace pde {
 class TemperatureSource : public Factory<TemperatureSource, const CFDSim&>
 {
 public:
-    static const std::string base_identifier() { return "TemperatureSource"; }
+    static std::string base_identifier() { return "TemperatureSource"; }
 
     ~TemperatureSource() override = default;
 

diff --git a/amr-wind/equation_systems/tke/TKESource.H b/amr-wind/equation_systems/tke/TKESource.H
@@ -19,7 +19,7 @@ namespace pde {
 class TKESource : public Factory<TKESource, const CFDSim&>
 {
 public:
-    static const std::string base_identifier() { return "TKESource"; }
+    static std::string base_identifier() { return "TKESource"; }
 
     ~TKESource() override = default;
 

diff --git a/amr-wind/equation_systems/tke/source_terms/KsgsM84Src.H b/amr-wind/equation_systems/tke/source_terms/KsgsM84Src.H
@@ -13,7 +13,7 @@ namespace tke {
 class KsgsM84Src : public TKESource::Register<KsgsM84Src>
 {
 public:
-    static const std::string identifier() { return "KsgsM84Src"; }
+    static std::string identifier() { return "KsgsM84Src"; }
 
     explicit KsgsM84Src(const CFDSim&);
 

diff --git a/amr-wind/equation_systems/tke/source_terms/KwSSTSrc.H b/amr-wind/equation_systems/tke/source_terms/KwSSTSrc.H
@@ -15,7 +15,7 @@ namespace tke {
 class KwSSTSrc : public TKESource::Register<KwSSTSrc>
 {
 public:
-    static const std::string identifier() { return "KwSSTSrc"; }
+    static std::string identifier() { return "KwSSTSrc"; }
 
     explicit KwSSTSrc(const CFDSim&);
 

diff --git a/amr-wind/immersed_boundary/IB.H b/amr-wind/immersed_boundary/IB.H
@@ -28,7 +28,7 @@ class ImmersedBoundaryModel;
 class IB : public Physics::Register<IB>
 {
 public:
-    static const std::string identifier() { return "IB"; }
+    static std::string identifier() { return "IB"; }
 
     explicit IB(CFDSim&);
 

diff --git a/amr-wind/immersed_boundary/bluff_body/Box.H b/amr-wind/immersed_boundary/bluff_body/Box.H
@@ -20,7 +20,7 @@ struct Box : public BluffBodyType
     using MetaType = BoxData;
     using DataType = IBDataHolder<Box>;
 
-    static const std::string identifier() { return "Box"; }
+    static std::string identifier() { return "Box"; }
 };
 
 } // namespace ib

diff --git a/amr-wind/immersed_boundary/bluff_body/Cylinder.H b/amr-wind/immersed_boundary/bluff_body/Cylinder.H
@@ -19,7 +19,7 @@ struct Cylinder : public BluffBodyType
     using MetaType = CylinderData;
     using DataType = IBDataHolder<Cylinder>;
 
-    static const std::string identifier() { return "Cylinder"; }
+    static std::string identifier() { return "Cylinder"; }
 };
 
 } // namespace ib

diff --git a/amr-wind/immersed_boundary/bluff_body/Sphere.H b/amr-wind/immersed_boundary/bluff_body/Sphere.H
@@ -18,7 +18,7 @@ struct Sphere : public BluffBodyType
     using MetaType = SphereData;
     using DataType = IBDataHolder<Sphere>;
 
-    static const std::string identifier() { return "Sphere"; }
+    static std::string identifier() { return "Sphere"; }
 };
 
 } // namespace ib

diff --git a/amr-wind/mesh_mapping_models/ChannelFlowMap.H b/amr-wind/mesh_mapping_models/ChannelFlowMap.H
@@ -12,7 +12,7 @@ namespace channel_map {
 class ChannelFlowMap : public MeshMap::Register<ChannelFlowMap>
 {
 public:
-    static const std::string identifier() { return "ChannelFlowMap"; }
+    static std::string identifier() { return "ChannelFlowMap"; }
 
     explicit ChannelFlowMap();
 

diff --git a/amr-wind/mesh_mapping_models/ConstantMap.H b/amr-wind/mesh_mapping_models/ConstantMap.H
@@ -12,7 +12,7 @@ namespace const_map {
 class ConstantMap : public MeshMap::Register<ConstantMap>
 {
 public:
-    static const std::string identifier() { return "ConstantMap"; }
+    static std::string identifier() { return "ConstantMap"; }
 
     explicit ConstantMap();
 

diff --git a/amr-wind/physics/BoussinesqBubble.H b/amr-wind/physics/BoussinesqBubble.H
@@ -15,7 +15,7 @@ namespace amr_wind {
 class BoussinesqBubble : public Physics::Register<BoussinesqBubble>
 {
 public:
-    static const std::string identifier() { return "BoussinesqBubble"; }
+    static std::string identifier() { return "BoussinesqBubble"; }
 
     explicit BoussinesqBubble(CFDSim& sim);
 

diff --git a/amr-wind/physics/ChannelFlow.H b/amr-wind/physics/ChannelFlow.H
@@ -15,7 +15,7 @@ namespace channel_flow {
 class ChannelFlow : public Physics::Register<ChannelFlow>
 {
 public:
-    static const std::string identifier() { return "ChannelFlow"; }
+    static std::string identifier() { return "ChannelFlow"; }
 
     explicit ChannelFlow(CFDSim& sim);
 

diff --git a/amr-wind/physics/ConvectingTaylorVortex.H b/amr-wind/physics/ConvectingTaylorVortex.H
@@ -89,7 +89,7 @@ struct GpzExact
 class ConvectingTaylorVortex : public Physics::Register<ConvectingTaylorVortex>
 {
 public:
-    static const std::string identifier() { return "ConvectingTaylorVortex"; }
+    static std::string identifier() { return "ConvectingTaylorVortex"; }
 
     explicit ConvectingTaylorVortex(const CFDSim& sim);
 

diff --git a/amr-wind/physics/EkmanSpiral.H b/amr-wind/physics/EkmanSpiral.H
@@ -13,7 +13,7 @@ namespace amr_wind {
 class EkmanSpiral : public Physics::Register<EkmanSpiral>
 {
 public:
-    static const std::string identifier() { return "EkmanSpiral"; }
+    static std::string identifier() { return "EkmanSpiral"; }
 
     explicit EkmanSpiral(const CFDSim& sim);
 

diff --git a/amr-wind/physics/FreeStream.H b/amr-wind/physics/FreeStream.H
@@ -19,7 +19,7 @@ namespace amr_wind {
 class FreeStream : public Physics::Register<FreeStream>
 {
 public:
-    static const std::string identifier() { return "FreeStream"; }
+    static std::string identifier() { return "FreeStream"; }
 
     explicit FreeStream(const CFDSim& sim);
 

diff --git a/amr-wind/physics/HybridRANSLESABL.H b/amr-wind/physics/HybridRANSLESABL.H
@@ -14,7 +14,7 @@ namespace hybrid_rans_les_abl {
 class HybridRANSLESABL : public Physics::Register<HybridRANSLESABL>
 {
 public:
-    static const std::string identifier() { return "HybridRANSLESABL"; }
+    static std::string identifier() { return "HybridRANSLESABL"; }
 
     explicit HybridRANSLESABL(const CFDSim& sim);
 

diff --git a/amr-wind/physics/RayleighTaylor.H b/amr-wind/physics/RayleighTaylor.H
@@ -17,7 +17,7 @@ namespace amr_wind {
 class RayleighTaylor : public Physics::Register<RayleighTaylor>
 {
 public:
-    static const std::string identifier() { return "RayleighTaylor"; }
+    static std::string identifier() { return "RayleighTaylor"; }
 
     explicit RayleighTaylor(const CFDSim& sim);
 

diff --git a/amr-wind/physics/SyntheticTurbulence.H b/amr-wind/physics/SyntheticTurbulence.H
@@ -147,7 +147,7 @@ struct InterpWeights
 class SyntheticTurbulence : public Physics::Register<SyntheticTurbulence>
 {
 public:
-    static const std::string identifier() { return "SyntheticTurbulence"; }
+    static std::string identifier() { return "SyntheticTurbulence"; }
 
     explicit SyntheticTurbulence(const CFDSim& sim);
 

diff --git a/amr-wind/physics/TaylorGreenVortex.H b/amr-wind/physics/TaylorGreenVortex.H
@@ -12,7 +12,7 @@ namespace amr_wind {
 class TaylorGreenVortex : public Physics::Register<TaylorGreenVortex>
 {
 public:
-    static const std::string identifier() { return "TaylorGreenVortex"; }
+    static std::string identifier() { return "TaylorGreenVortex"; }
 
     explicit TaylorGreenVortex(const CFDSim& sim);
 

diff --git a/amr-wind/physics/VortexRing.H b/amr-wind/physics/VortexRing.H
@@ -12,7 +12,7 @@ namespace amr_wind {
 class VortexRing : public Physics::Register<VortexRing>
 {
 public:
-    static const std::string identifier() { return "VortexRing"; }
+    static std::string identifier() { return "VortexRing"; }
 
     explicit VortexRing(const CFDSim& sim);
 

diff --git a/amr-wind/physics/multiphase/DamBreak.H b/amr-wind/physics/multiphase/DamBreak.H
@@ -14,7 +14,7 @@ namespace amr_wind {
 class DamBreak : public Physics::Register<DamBreak>
 {
 public:
-    static const std::string identifier() { return "DamBreak"; }
+    static std::string identifier() { return "DamBreak"; }
 
     explicit DamBreak(CFDSim& sim);
 

diff --git a/amr-wind/physics/multiphase/MultiPhase.H b/amr-wind/physics/multiphase/MultiPhase.H
@@ -22,7 +22,7 @@ enum class InterfaceCapturingMethod {
 class MultiPhase : public Physics::Register<MultiPhase>
 {
 public:
-    static const std::string identifier() { return "MultiPhase"; }
+    static std::string identifier() { return "MultiPhase"; }
 
     explicit MultiPhase(CFDSim& sim);
 

diff --git a/amr-wind/physics/multiphase/RainDrop.H b/amr-wind/physics/multiphase/RainDrop.H
@@ -16,7 +16,7 @@ class RainDrop : public Physics::Register<RainDrop>
     static_assert(AMREX_SPACEDIM == 3, "RainDrop requires 3 dimensional mesh");
 
 public:
-    static const std::string identifier() { return "RainDrop"; }
+    static std::string identifier() { return "RainDrop"; }
 
     explicit RainDrop(CFDSim& sim);
 

diff --git a/amr-wind/physics/multiphase/SloshingTank.H b/amr-wind/physics/multiphase/SloshingTank.H
@@ -14,7 +14,7 @@ namespace amr_wind {
 class SloshingTank : public Physics::Register<SloshingTank>
 {
 public:
-    static const std::string identifier() { return "SloshingTank"; }
+    static std::string identifier() { return "SloshingTank"; }
 
     explicit SloshingTank(CFDSim& sim);
 

diff --git a/amr-wind/physics/multiphase/VortexPatch.H b/amr-wind/physics/multiphase/VortexPatch.H
@@ -17,7 +17,7 @@ class VortexPatch : public Physics::Register<VortexPatch>
         AMREX_SPACEDIM == 3, "VortexPatch requires 3 dimensional mesh");
 
 public:
-    static const std::string identifier() { return "VortexPatch"; }
+    static std::string identifier() { return "VortexPatch"; }
 
     explicit VortexPatch(CFDSim& sim);
 

diff --git a/amr-wind/physics/multiphase/ZalesakDisk.H b/amr-wind/physics/multiphase/ZalesakDisk.H
@@ -18,7 +18,7 @@ class ZalesakDisk : public Physics::Register<ZalesakDisk>
         AMREX_SPACEDIM == 3, "ZalesakDisk requires 3 dimensional mesh");
 
 public:
-    static const std::string identifier() { return "ZalesakDisk"; }
+    static std::string identifier() { return "ZalesakDisk"; }
 
     explicit ZalesakDisk(CFDSim& sim);
 

diff --git a/amr-wind/physics/multiphase/wave_basin/NWB.H b/amr-wind/physics/multiphase/wave_basin/NWB.H
@@ -30,7 +30,7 @@ namespace amr_wind {
 class NWB : public Physics::Register<NWB>
 {
 public:
-    static const std::string identifier() { return "NWB"; }
+    static std::string identifier() { return "NWB"; }
 
     explicit NWB(CFDSim& sim);