Fix FPE arising from ssq == Rsq (Exawind#559)

* Fix FPE arising from ssq == Rsq * Initializing the vector potential to zero
stephan-rohr · Jan 31, 2022 · 90b7d4f · 90b7d4f
1 parent fbc58ec
commit 90b7d4f
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/amr-wind/physics/VortexRing.cpp b/amr-wind/physics/VortexRing.cpp
@@ -25,7 +25,7 @@ AMREX_GPU_HOST_DEVICE AMREX_FORCE_INLINE amrex::Real FatCore::operator()(
 {
     amrex::Real Rsq = std::pow(R, 2);
     const amrex::Real ssq = std::pow(z, 2) + std::pow(r - R, 2);
-    if (ssq <= Rsq) {
+    if (ssq < Rsq) {
         return 0.54857674 * Gamma / Rsq * std::exp(-4 * ssq / (Rsq - ssq));
     }
     return 0.0;
@@ -235,7 +235,9 @@ void VortexRing::initialize_velocity(const VortexRingType& vorticity_theta)
     const amrex::Real rel_tol = 1.0e-13;
     const amrex::Real abs_tol = 1.0e-13;
 
-    (*vectorpotential)(0).setVal(0.0, 0, AMREX_SPACEDIM, 1);
+    for (int level = 0; level <= m_repo.mesh().finestLevel(); ++level) {
+        (*vectorpotential)(level).setVal(0.0, 0, AMREX_SPACEDIM, 1);
+    }
 
     // might be able to skip z-dir since vorticity is 0.0
     for (int i = 0; i < AMREX_SPACEDIM; ++i) {