Suppress false positive cppcheck warnings (Exawind#638)

stephan-rohr · Jun 21, 2022 · 0100478 · 0100478
1 parent a8c8795
commit 0100478
Show file tree

Hide file tree

Showing 8 changed files with 19 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -303,7 +303,7 @@ jobs:
             source ${SPACK_MANAGER}/start.sh && \
             ln -s ${GITHUB_WORKSPACE} amr-wind && \
             source ${SPACK_MANAGER}/start.sh && \
-            quick-develop -s amr-wind+hdf5+hypre+masa+netcdf~shared@main && \
+            quick-develop -s amr-wind+ascent+hdf5+hypre+masa+netcdf~shared@main && \
             spack install && \
             spack cd -b amr-wind && \
             spack build-env amr-wind ctest -j $(nproc) -L unit --output-on-failure \

diff --git a/amr-wind/equation_systems/icns/icns_diffusion.H b/amr-wind/equation_systems/icns/icns_diffusion.H
@@ -430,6 +430,7 @@ public:
     {
         const FieldState fstate = FieldState::New;
         auto& repo = m_pdefields.repo;
+        // cppcheck-suppress constVariable
         auto& field = m_pdefields.field;
         const auto& density = m_density.state(fstate);
         const int nlevels = repo.num_active_levels();

diff --git a/amr-wind/turbulence/LES/OneEqKsgs.cpp b/amr-wind/turbulence/LES/OneEqKsgs.cpp
@@ -12,6 +12,7 @@ namespace amr_wind {
 namespace turbulence {
 
 template <typename Transport>
+// cppcheck-suppress uninitMemberVar
 OneEqKsgs<Transport>::OneEqKsgs(CFDSim& sim)
     : TurbModelBase<Transport>(sim)
     , m_vel(sim.repo().get_field("velocity"))

diff --git a/amr-wind/turbulence/LES/Smagorinsky.cpp b/amr-wind/turbulence/LES/Smagorinsky.cpp
@@ -11,6 +11,7 @@ namespace amr_wind {
 namespace turbulence {
 
 template <typename Transport>
+// cppcheck-suppress uninitMemberVar
 Smagorinsky<Transport>::Smagorinsky(CFDSim& sim)
     : TurbModelBase<Transport>(sim)
     , m_vel(sim.repo().get_field("velocity"))

diff --git a/amr-wind/wind_energy/ABLFieldInit.cpp b/amr-wind/wind_energy/ABLFieldInit.cpp
@@ -111,7 +111,10 @@ void ABLFieldInit::operator()(
 }
 
 void ABLFieldInit::perturb_temperature(
-    const int lev, const amrex::Geometry& geom, Field& temperature) const
+    const int lev,
+    const amrex::Geometry& geom,
+    // cppcheck-suppress constParameter
+    Field& temperature) const
 {
     /** Perturbations for the temperature field is adapted from the following
      * paper:

diff --git a/amr-wind/wind_energy/ABLStats.cpp b/amr-wind/wind_energy/ABLStats.cpp
@@ -15,7 +15,9 @@ namespace amr_wind {
 namespace {
 struct TemperatureGradient
 {
+    // cppcheck-suppress unusedStructMember
     double grad_z;
+    // cppcheck-suppress unusedStructMember
     double max_grad_loc;
 };
 } // namespace

diff --git a/amr-wind/wind_energy/actuator/disk/disk_ops.cpp b/amr-wind/wind_energy/actuator/disk/disk_ops.cpp
@@ -257,15 +257,17 @@ std::ostringstream check_for_parse_conflicts(const utils::ActParser& pp)
 {
     std::ostringstream error_collector;
 
-    // clang-format off
     collect_parse_conflicts(pp, "disk_normal", "yaw", error_collector);
     collect_parse_conflicts(pp, "disk_normal", "tilt", error_collector);
     collect_parse_conflicts(pp, "sample_normal", "sample_yaw", error_collector);
-    collect_parse_conflicts(pp, "sample_normal", "sample_tilt", error_collector);
-    collect_parse_conflicts(pp, "disk_center", "base_position", error_collector);
+    collect_parse_conflicts(
+        pp, "sample_normal", "sample_tilt", error_collector);
+    collect_parse_conflicts(
+        pp, "disk_center", "base_position", error_collector);
     collect_parse_conflicts(pp, "disk_center", "hub_height", error_collector);
-    collect_parse_dependencies(pp, "base_position", "hub_height", error_collector);
-    // clang-format on
+    collect_parse_dependencies(
+        pp, "base_position", "hub_height", error_collector);
+
     RealList ct;
     pp.getarr("thrust_coeff", ct);
     if (ct.size() > 1) {
@@ -379,4 +381,4 @@ void compute_disk_points(
 } // namespace base
 } // namespace ops
 } // namespace actuator
-} // namespace amr_wind
+} // namespace amr_wind
diff --git a/unit_tests/utilities/test_wave_energy.cpp b/unit_tests/utilities/test_wave_energy.cpp
@@ -59,6 +59,7 @@ void init_vof(amr_wind::Field& fld)
 class WaveEnergyImpl : public amr_wind::wave_energy::WaveEnergy
 {
 public:
+    // cppcheck-suppress passedByValue
     WaveEnergyImpl(amr_wind::CFDSim& sim, std::string label)
         : amr_wind::wave_energy::WaveEnergy(sim, label)
     {}