feat(Claim): Claim type

[rgieseke]

A very first attempt at a Claim spec.
See discussion in stencila/encoda#885

Not quite sure about title and claimType. Should the kind be pre-specified, not sure ...

[codecov-io]

Codecov Report

Merging #255 (eb7ed70) into master (379cf19) will not change coverage.
The diff coverage is n/a.

❗ Current head eb7ed70 differs from pull request most recent head 1d08d57. Consider uploading reports for the commit 1d08d57 to get more accurate results

@@           Coverage Diff           @@
##           master     #255   +/-   ##
=======================================
  Coverage   96.28%   96.28%           
=======================================
  Files          10       10           
  Lines         296      296           
  Branches       72       72           
=======================================
  Hits          285      285           
  Misses         11       11           

Flag	Coverage Δ
py	98.03% <ø> (ø)
ts	95.91% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379cf19...1d08d57. Read the comment docs.

[nokome]

Thank you @rgieseke 🙏🏽 . Loving these PR's keep 'em coming! 🙂

Looks good, I have made some suggestions for further improvements. Also, could you please add Claim to BlockContent.schema.yaml.

[rgieseke]

Thank you for prompt feedback and guidance! 🙇‍♂️
Do you have a preference how commit messages (with GitHub suggestions i don't get the gentle nudges)?
Should they be rebased before a merge?

[nokome]

Do you have a preference how commit messages (with GitHub suggestions i don't get the gentle nudges)?

Thanks for asking. I've added a guide here and installed this on the repo for nudges. No need to change your existing commit messages.

Should they be rebased before a merge?

No need, but feel free to if it makes merge conflicts go away for example

[rgieseke]

Not sure what went wrong in the pipeline, look like a TypeScript deployment problem: https://dev.azure.com/stencila/stencila/_build/results?buildId=11540&view=logs&j=58ad7040-9663-5369-9bcd-5f12d621aae7&t=8a0fbeb0-5fa0-5945-0376-86428f92b037

[nokome]

Not sure what went wrong in the pipeline, look like a TypeScript deployment problem

The problem was that we were attempting to release docs to GitHub pages on an external PR using an internal token, which Azure Pipelines rightly refuses access to. I've added a condition to only release TS docs on tags (as for other langs).

I also noticed that @id should be schema:Claim since this is an existing schema.org type and that label was incorrectly indented. Lastly, I've ordered the properties alphabetically as it's our loose convention.

[stencila-ci]

🎉 This PR is included in version 1.3.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[rgieseke]

I also noticed that @id should be schema:Claim since this is an existing schema.org type and that label was incorrectly indented. Lastly, I've ordered the properties alphabetically as it's our loose convention.

Good catch and i learnt another thing, thanks! :-)