fix workflows

stemmlerjs · Jul 2, 2024 · 534a3ab · 534a3ab
1 parent 7ba5fbd
commit 534a3ab
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 15 deletions.
diff --git a/...fCraftship/2_best_practice_first/deployment/assignment/end/.github/workflows/1-commit.yml b/...fCraftship/2_best_practice_first/deployment/assignment/end/.github/workflows/1-commit.yml
@@ -3,7 +3,7 @@ name: Commit Phase
 on:
   push:
     branches:
-      - bp-first-assignments-deployment # or specify your desired branch
+      - main # or specify your desired branch
 
 jobs:
   lint-build-test-archive:
@@ -19,7 +19,7 @@ jobs:
           node-version: 16.16
 
       - name: Install
-        run: npm ci
+        run: npm i
 
       # - name: Lint
       #   run: npm run lint
@@ -28,13 +28,4 @@ jobs:
         run: npm run build
 
       - name: Test (core unit tests)
-        run: npm run test:unit
-
-      - name: Archive Frontend
-        id: frontend-build
-        uses: actions/upload-artifact@v2
-        with:
-          name: frontend-build-latest
-          path: ./packages/frontend/dist
-          # Customize Artifact Retention Period
-          retention-days: 2
+        run: npm run test:unit
diff --git a/...fCraftship/2_best_practice_first/deployment/assignment/end/.github/workflows/2-deploy.yml b/...fCraftship/2_best_practice_first/deployment/assignment/end/.github/workflows/2-deploy.yml
@@ -1,9 +1,10 @@
 name: Automatically Deploy to Staging and Production
 
 on:
-  push:
-    branches:
-      - bp-first-assignments-deployment # or specify your desired branch
+  workflow_run:
+    workflows: ["Commit Phase"]
+    types:
+      - completed
 
 jobs:
   ci: