This repository has been archived by the owner on Jun 17, 2024. It is now read-only.
Fix several bugs #88
Merged
Fix several bugs #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @stellasia I'm just back online after such a long while. Reviewing now! |
|
Hi @JoDoM ! Thanks! My goal here is just to fix the master branch, so that we can start adding features again. But open to discussion on the best way to do it of course :) |
* enhanced master fix * map and layer pane fixes * update layer tests
This was referenced Jan 30, 2021
stellasia
added a commit
that referenced
this pull request
Sep 17, 2021
* Create CONTRIBUTING.md * Update README.md * Update CONTRIBUTING.md * Fix overflow * Publish package to NPM * Fix for CI and publish * Remove Redux (#71) * package bump * remove redux packages * remove redux logic * remove actions, reducers and store * update spec imports * Trigger github action on both push and PR * Test with jest (#73) * package bump * remove redux packages * remove redux logic * remove actions, reducers and store * update spec imports * replace enzyme with jest * delete old specs and restructure code * add test structure * zero binds for local functions * refactor and debug tests * act on clicks * delete old layers folder * delete old layer spec * rewrite sidebaar to functional component * rewrite App as a functional component * Remove nodejs 8 from CI workflow * move seed data to consts * rewrite sidebar as fucntional component * rewrite menu as functional component * ref to loaded driver * rewrite map component as function * review map and add test data * sequence full map operations * mock out leaflet * usable test data, pause ut on map * rewrite color picker as functional component * singleton neo4j driver and service * formalise error and result api on neo4jservice * use error and result apiin layer ui * fix map reinstantiation error * format leaflet mock * fix result filters * optimise create driver * dry session runner * scaffold neo4j service tests * tests and service refactors * fix token fetch for driver init * fix records query * Fix several bugs (#88) * Make the app work again... * Enhanced master fix (#89) * enhanced master fix * map and layer pane fixes * update layer tests * class => className * Do not force name (for now) Co-authored-by: Konuko Jodom <[email protected]> * Several fixes, including #81 and #82 * Fix tests (?) * re-generate lock file Co-authored-by: Konuko Jodom <[email protected]> Co-authored-by: nikita <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the app work again