add examples for sep-10 #162
Conversation
| @@ -0,0 +1,56 @@ | |||
| /* eslint-disable */ | |||
|
|
|||
| // @ts-expect-error: express will need to be installed to run this example | |||
There was a problem hiding this comment.
I thought it was maybe overkill to add express to the repo just for this example, so I just added this as a comment. Let me know if it's worth adding it so a user can actually spin this up from this repo
There was a problem hiding this comment.
Is it too heavy? I'm personally fine adding it as a dev dependency as we could use it for other examples as well, but also OK in case you think that's too much
There was a problem hiding this comment.
I guess it won't affect the bundle size of the library, either. I'll add this as a dev dep 👍
|
No dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No dependency changes detected in pull request |
| @@ -69,6 +70,7 @@ | |||
| "build:web": "webpack --config webpack.config.js", | |||
| "build:node": "webpack --env NODE=true --config webpack.config.js", | |||
| "build": "run-p build:web build:node", | |||
| "example:sep10": "ts-node examples/sep10/sep10Server.ts", | |||
There was a problem hiding this comment.
how should we runsep10Wallet ?
There was a problem hiding this comment.
Ah good call. I wasn't sure if this was useful to run as it's a simple helper, but I can add it!
No description provided.