Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break getTransactionsByLedgerSequence into smaller sub-functions #244

Merged
merged 14 commits into from
Jul 25, 2024

Conversation

aditya1702
Copy link
Contributor

What

#211

Why

Function was very long. Shortened it for readability.

Known limitations

NA

@aditya1702 aditya1702 requested review from 2opremio and Shaptic July 9, 2024 18:45
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a coupla comments but otherwise LGTM!

cmd/soroban-rpc/internal/methods/get_transactions.go Outdated Show resolved Hide resolved
cmd/soroban-rpc/internal/methods/get_transactions.go Outdated Show resolved Hide resolved
cmd/soroban-rpc/internal/methods/get_transactions.go Outdated Show resolved Hide resolved
cmd/soroban-rpc/internal/methods/get_transactions.go Outdated Show resolved Hide resolved
@aditya1702 aditya1702 requested review from Shaptic and 2opremio July 23, 2024 21:11
Copy link
Contributor

@Shaptic Shaptic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a couple minor things to optionally consider 👍

@aditya1702 aditya1702 merged commit 2d6faac into stellar:main Jul 25, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants