Add getTransactions endpoint
#136
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -139,14 +139,14 @@ LedgerLoop: | |
| for ledgerSeq := start.LedgerSequence; ledgerSeq <= int32(ledgerRange.LastLedger.Sequence); ledgerSeq++ { | ||
| // Get ledger close meta from db | ||
| ledger, found, err := h.ledgerReader.GetLedger(ctx, uint32(ledgerSeq)) | ||
| if !found { | ||
aditya1702 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| return GetTransactionsResponse{}, &jrpc2.Error{ | ||
| Code: jrpc2.InvalidParams, | ||
| Message: errors.Errorf("ledger close meta not found: %d", ledgerSeq).Error(), | ||
| } | ||
| } else if err != nil { | ||
| return GetTransactionsResponse{}, &jrpc2.Error{ | ||
| Code: jrpc2.InternalError, | ||
|
There was a problem hiding this comment. why internal now? if it's not in the DB then their request is out of bounds There was a problem hiding this comment. same comment for all of the below error changes imo There was a problem hiding this comment. @Shaptic Yeah you are correct. I refactored this code again to use InvalidParams for "ledger close meta not found" or for any other db related error, use the InternalError code. However, for these 3 errors:
InternalError would make more sense dont you think? Since they are generated due to some internal parsing issues? |
||
| Message: err.Error(), | ||
| } | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a thought for the future: we should probably do something more like
getLedgers()and then process ledgers in batches so that we don't have to have one SQL query for each iteration (while still respectinglimit, of course, but a little extra memory is worth saving queries).We can include this as part of (or after, at the very least) the
getLedgerswork in #111.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shaptic Yeah I agree. We should do the batch processing as its more efficient.