adding ledgerbackend datastore txmeta as a data source #235
Conversation
There was a problem hiding this comment.
Great start for ETL refactor. Small nit to get the unit test passing for operation_trace_code again.
I agree with all of your TODOs listed and think we should document them in tickets to be working in an upcoming sprint.
Did you test the code using the captive_core flag to confirm that the code is backwards compatible?
cmd/export_assets.go
Outdated
| paymentOps, err = input.GetPaymentOperationsHistoryArchive(startNum, endNum, limit, isTest, isFuture) | ||
| } else { | ||
| paymentOps, err = input.GetPaymentOperations(startNum, endNum, limit, env, useCaptiveCore) |
There was a problem hiding this comment.
I like your idea of eventually refactoring this History Archives method to use lcm directly. I think it's cleaner and less confusing
I see that the test CDP DAGs only use one |
|
Before merging:
|
|
|
||
| // AccountSignersChanged returns true if account signers have changed. | ||
| // Notice: this will return true on master key changes too! | ||
| func AccountSignersChanged(c ingest.Change) bool { |
There was a problem hiding this comment.
This function was removed from the ingest library. Needed for account signers
Integrate cdp changes to ingest from datastore txmeta files