Merge pull request #199 from stellar/fix-diagnostic-event-bug

Fix diagnostic event parsing bug
stellar · Oct 3, 2023 · 1132c44 · 1132c44
2 parents 4053d24 + 3a283de
commit 1132c44
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/internal/input/changes.go b/internal/input/changes.go
@@ -89,7 +89,8 @@ func extractBatch(
 		xdr.LedgerEntryTypeClaimableBalance,
 		xdr.LedgerEntryTypeContractData,
 		xdr.LedgerEntryTypeContractCode,
-		xdr.LedgerEntryTypeConfigSetting}
+		xdr.LedgerEntryTypeConfigSetting,
+		xdr.LedgerEntryTypeExpiration}
 
 	changes := map[xdr.LedgerEntryType][]ingest.Change{}
 	ctx := context.Background()

diff --git a/internal/transform/diagnostic_events.go b/internal/transform/diagnostic_events.go
@@ -34,11 +34,11 @@ func TransformDiagnosticEvent(transaction ingest.LedgerTransaction, lhe xdr.Ledg
 	var transformedDiagnosticEvents []DiagnosticEventOutput
 
 	for _, diagnoticEvent := range transactionMeta.SorobanMeta.DiagnosticEvents {
+		var outputContractId string
+
 		outputInSuccessfulContractCall := diagnoticEvent.InSuccessfulContractCall
 		event := diagnoticEvent.Event
 		outputExtV := event.Ext.V
-		contractIdByte, _ := event.ContractId.MarshalBinary()
-		outputContractId, _ := strkey.Encode(strkey.VersionByteContract, contractIdByte)
 		outputType := event.Type.String()
 		outputBodyV := event.Body.V
 		body, ok := event.Body.GetV0()
@@ -51,6 +51,12 @@ func TransformDiagnosticEvent(transaction ingest.LedgerTransaction, lhe xdr.Ledg
 			continue
 		}
 
+		if event.ContractId != nil {
+			contractId := *event.ContractId
+			contractIdByte, _ := contractId.MarshalBinary()
+			outputContractId, _ = strkey.Encode(strkey.VersionByteContract, contractIdByte)
+		}
+
 		transformedDiagnosticEvent := DiagnosticEventOutput{
 			TransactionHash:          outputTransactionHash,
 			LedgerSequence:           outputLedgerSequence,