Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update BQ schema and bump airflow/dbt images #435

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Update BQ schema and bump airflow/dbt images #435

merged 4 commits into from
Jul 22, 2024

Conversation

amishas157
Copy link
Contributor

@amishas157 amishas157 commented Jul 17, 2024 •
edited
Loading

PR Checklist

PR Structure

  • This PR has reasonably narrow scope (if not, break it down into smaller PRs).
  • This PR avoids mixing refactoring changes with feature changes (split into two PRs
    otherwise).
  • This PR's title starts with the jira ticket associated with the PR.

Thoroughness

  • This PR adds tests for the most critical parts of the new functionality or fixes.
  • I've updated the README with the added features, breaking changes, new instructions on how to use the repository.

What

This PR updates etl image and DBT image so as to update the data type of AssetType for Trustlines tables from integer to string.
Related PRs:

Why

This is done to make AssetType consistent across all the schemas as it was mistakenly added as integer earlier.

Known limitations

None. Deploy plan posted in Jira

@amishas157 amishas157 marked this pull request as ready for review July 22, 2024 15:47
@amishas157 amishas157 requested a review from a team as a code owner July 22, 2024 15:47
@amishas157 amishas157 changed the title update BQ schema Update BQ schema and bump airflow/dbt images Jul 22, 2024
chowbao
chowbao approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@chowbao chowbao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just needs image updates to the airflow_variables_dev.json and airflow_variable_prod.json after stellar-etl is merged

@amishas157 amishas157 merged commit 27f5a2c into master Jul 22, 2024
4 checks passed
amishas157 added a commit that referenced this pull request Jul 22, 2024
@amishas157
Update BQ schema and bump airflow/dbt images (#435)
f78a33e 
* update BQ schema

* update with test image ref

* update etl and dbt images
chowbao added a commit that referenced this pull request Jul 22, 2024
@chowbao
Revert "Update BQ schema and bump airflow/dbt images (#435)"
2006d90 
This reverts commit 27f5a2c.
@chowbao chowbao mentioned this pull request Jul 22, 2024
Merged
chowbao added a commit that referenced this pull request Jul 22, 2024
@chowbao
Revert "Update BQ schema and bump airflow/dbt images (#435)" (#445)
dcb8354 
This reverts commit 27f5a2c.
@amishas157 amishas157 mentioned this pull request Jul 22, 2024
Merged
5 tasks
@amishas157 amishas157 deleted the feature/update-asset-type-to-string branch July 26, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chowbao chowbao chowbao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amishas157 @chowbao