Update airflow resources and split out dbt tests and alerts #433
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -18,7 +18,7 @@ | |
| default_args=get_default_dag_args(), | ||
| start_date=datetime(2024, 6, 25, 0, 0), | ||
| description="This DAG runs dbt tests and Elementary alerts at a half-hourly cadence", | ||
| schedule="*/15 * * * *", # Runs every 15 minutes | ||
| user_defined_filters={ | ||
| "container_resources": lambda s: k8s.V1ResourceRequirements(requests=s), | ||
| }, | ||
|
|
@@ -28,14 +28,7 @@ | |
| # sla_miss_callback=alert_sla_miss, | ||
| ) as dag: | ||
|
|
||
| # Trigger elementary | ||
| elementary_alerts = elementary_task(dag, "dbt_data_quality", resource_cfg="dbt") | ||
|
|
||
|
There was a problem hiding this comment. This looks good. But curious why were we using empty operator?
|
||
| elementary_alerts | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| from datetime import datetime | ||
|
|
||
| from airflow import DAG | ||
| from airflow.operators.empty import EmptyOperator | ||
| from kubernetes.client import models as k8s | ||
| from stellar_etl_airflow.build_dbt_task import dbt_task | ||
| from stellar_etl_airflow.build_elementary_slack_alert_task import elementary_task | ||
| from stellar_etl_airflow.default import ( | ||
| alert_sla_miss, | ||
| get_default_dag_args, | ||
| init_sentry, | ||
| ) | ||
|
|
||
| init_sentry() | ||
|
|
||
| with DAG( | ||
| "dbt_singular_tests", | ||
| default_args=get_default_dag_args(), | ||
| start_date=datetime(2024, 6, 25, 0, 0), | ||
| description="This DAG runs non-model dbt tests half-hourly cadence", | ||
| schedule="*/30 * * * *", # Runs every 30 minutes | ||
| user_defined_filters={ | ||
| "container_resources": lambda s: k8s.V1ResourceRequirements(requests=s), | ||
| }, | ||
| max_active_runs=1, | ||
| catchup=False, | ||
| tags=["dbt-data-quality"], | ||
| # sla_miss_callback=alert_sla_miss, | ||
| ) as dag: | ||
|
|
||
| # DBT tests to run | ||
| singular_tests = dbt_task( | ||
| dag, | ||
| command_type="test", | ||
| tag="singular_test", | ||
| resource_cfg="dbt", | ||
| ) | ||
|
|
||
| singular_tests |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we're no longer separating resources out between dbt, default and stellaretl, is it worth us storing configs beyond the
default?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's worth it. I was going to delete all the resources and just make everything run with the default settings but I have a theory that dbt and stellar-etl both have different resource requirements. So in the case we do need to bump up/down resources for one service we wouldn't necessarily OOM or over-allocate the other service
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👌 sounds good to me. Your theory sounds plausible