Update READMEs #363
Merged
Update READMEs #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
README.md
Outdated
| | public_source_db | Name of the BigQuery [project](https://cloud.google.com/resource-manager/docs/creating-managing-projects#console) | Yes. Change to your project name. | | ||
| | public_source_schema | Name of the BigQuery [dataset](https://cloud.google.com/bigquery/docs/datasets) | Yes. Change to your dataset name. | | ||
| | slack_elementary_channel | Name of slack channel to send elementary alerts | Yes. Change to your slack channel name. | | ||
| | elementary_secret | Name of the slack secret to use to send alerts to slack | Yes. Change to your secret name. | |
There was a problem hiding this comment.
Mmmmm should this be an airflow var? Or should it be saved in GCP secrets?
There was a problem hiding this comment.
I think it is saved in the GCP secrets but this is the name of the secret in GCP secrets lol
There was a problem hiding this comment.
I'll remove it for now as we should refactor it so we don't provide the name of the secret
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.