-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description of nomination leader election algorithm #990
Conversation
Preview is available here: |
Are we leaving out "CRITICAL" on purpose? I opened an issue about it yesterday for another part of the docs: #985 |
Couple editorial nits but will defer to @marta-lokhova for content correctness and approval 🙏 |
Preview is available here: |
Thanks for documenting leader election! I have a similar question to @nano-o's - do we want to mention CRITICAL quality as well? |
The problem is that there's no mention of CRITICAL anywhere else in the docs, so I think it would be wrong/confusing to mention it only in the nomination leader election section. We could add a description of CRITICAL to the admin docs, but I'm not sure whether CRITICAL was intentionally left out of the docs, which is what I think @nano-o's question is getting at. |
After some discussion with @marta-lokhova we decided to add a generic, level-agnostic description of the algorithm, as well as an example using HIGH, MEDIUM, and LOW quality validators. I'll make that change and ping @marta-lokhova when it's ready. |
Part of stellar/stellar-core#4387 This change adds a section to the admin guide explaining the impact of validator quality levels on SCP nomination leader election.
61007f7
to
08e671f
Compare
I just pushed up a change that accomplishes this, and rebased on |
Preview is available here: |
Part of stellar/stellar-core#4387
This change adds a section to the admin guide explaining the impact of validator quality levels on SCP nomination leader election.