Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tip about missing wasm32 target. #946

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Add tip about missing wasm32 target. #946

merged 1 commit into from
Aug 28, 2024

Conversation

fnando
Copy link
Member

@fnando fnando commented Aug 27, 2024

CleanShot 2024-08-27 at 12 09 50

@stellar-jenkins
Copy link

Preview is available here:
http://developers-pr946.previews.kube001.services.stellar-ops.com

willemneal
willemneal approved these changes Aug 27, 2024
View reviewed changes
Copy link
Member

@willemneal willemneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I have I approval permissions in this repo but it looks good to me!

@janewang janewang merged commit b37840c into main Aug 28, 2024
2 checks passed
@janewang janewang deleted the wasm32-target-tip branch August 28, 2024 16:20
janewang pushed a commit that referenced this pull request Sep 12, 2024
@fnando @janewang
Add tip about missing wasm32 target. (#946)
541b153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willemneal willemneal willemneal approved these changes

@leighmcculloch leighmcculloch leighmcculloch approved these changes

@ElliotFriend ElliotFriend Awaiting requested review from ElliotFriend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fnando @stellar-jenkins @leighmcculloch @willemneal @janewang