[ANCHOR-749] Add SEP-38 validation documentation #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipliu
reviewed
Aug 26, 2024
| If the validation fails, the Platform will respond to the client application's request with a HTTP status | ||
| code of `502 Bad Gateway`. | ||
|
|
||
| The `sell_mount`, `buy_amount`, `price`, and `fee` are validated as follows: |
| The `sell_mount`, `buy_amount`, `price`, and `fee` are validated as follows: | ||
|
|
||
| - if `rate.fee` exists, | ||
| - `rate.fee.asset` must be defined with proper `significant_decimals` in the asset configuration. |
There was a problem hiding this comment.
What does proper mean here?
There was a problem hiding this comment.
Exists and positive.
|
Preview is available here: |
|
Preview is available here: |
philipliu
approved these changes
Aug 26, 2024
| @@ -718,7 +718,7 @@ Fetches a list of receivers within a specific disbursement using the disbursemen | |||
| required={false} | |||
There was a problem hiding this comment.
We should remove the SDP changes.
|
Preview is available here: |
|
Preview is available here: |
1 similar comment
|
Preview is available here: |
…-749-update-sep38-quote-validation-v2
|
Preview is available here: |
janewang
pushed a commit
that referenced
this pull request
Sep 12, 2024
* Add SEP-38 validation rules --------- Co-authored-by: Elliot Voris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*** Recreated due to operation mistake
Many validation rules are added to the response of the /rate endpoint. This PR adds the validations that may not be straight forward to the endpoint developers.